From fbe17b3842a7d28e3c9b776321ad4d58076c92f5 Mon Sep 17 00:00:00 2001 From: Kylesoda <249518290+kylesoda@users.noreply.github.com> Date: Sun, 26 Apr 2026 01:33:34 -0500 Subject: [PATCH] refactor: unify db dialect definition in dbdialects package --- internal/app/db-wrapper/db-dialects/main.go | 7 +++++++ internal/app/db-wrapper/mssql.go | 5 +++-- internal/app/db-wrapper/postgres.go | 5 +++-- 3 files changed, 13 insertions(+), 4 deletions(-) create mode 100644 internal/app/db-wrapper/db-dialects/main.go diff --git a/internal/app/db-wrapper/db-dialects/main.go b/internal/app/db-wrapper/db-dialects/main.go new file mode 100644 index 0000000..72d74f1 --- /dev/null +++ b/internal/app/db-wrapper/db-dialects/main.go @@ -0,0 +1,7 @@ +package dbdialects + +const ( + SqlServer string = "sqlserver" + Postgres string = "postgres" + Null string = "null" +) diff --git a/internal/app/db-wrapper/mssql.go b/internal/app/db-wrapper/mssql.go index 6de9611..19ab9a9 100644 --- a/internal/app/db-wrapper/mssql.go +++ b/internal/app/db-wrapper/mssql.go @@ -5,12 +5,13 @@ import ( "database/sql" "fmt" + dbdialects "git.ksdemosapps.com/kylesoda/go-migrate/internal/app/db-wrapper/db-dialects" mssql "github.com/microsoft/go-mssqldb" ) func init() { - Register("sqlserver", func() DbWrapper { - return &mssqlDbWrapper{dialect: "sqlserver"} + Register(dbdialects.SqlServer, func() DbWrapper { + return &mssqlDbWrapper{dialect: dbdialects.SqlServer} }) } diff --git a/internal/app/db-wrapper/postgres.go b/internal/app/db-wrapper/postgres.go index e6a1f37..5d699f3 100644 --- a/internal/app/db-wrapper/postgres.go +++ b/internal/app/db-wrapper/postgres.go @@ -4,13 +4,14 @@ import ( "context" "errors" + dbdialects "git.ksdemosapps.com/kylesoda/go-migrate/internal/app/db-wrapper/db-dialects" "github.com/jackc/pgx/v5" "github.com/jackc/pgx/v5/pgxpool" ) func init() { - Register("postgres", func() DbWrapper { - return &postgresDbWrapper{dialect: "postgres"} + Register(dbdialects.Postgres, func() DbWrapper { + return &postgresDbWrapper{dialect: dbdialects.Postgres} }) }